lkml.org 
[lkml]   [2005]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix user data corrupted by old value return of sysctl
    2005/12/31, Yi Yang <yang.y.yi@gmail.com>:
    > Coywolf Qi Hunt wrote:
    > >You didn't set the trailing '\0', I wonder how your printf did work
    > >properly ever. You've just been lucky or something.
    > >
    > >-- Coywolf
    > >
    > >
    > The variable target does it, its value is 0x00000001, so you mustn't
    > worry it.
    > osname only has 4-bytes space, so if you set '\0' to its tail, a byte
    > information will be lost.

    I'm worrying more. We should set '\0'. Let the one byte information
    lost, the caller deserve that. Actually here printf sees "mylo"+'\01'
    if little endian.

    Linus, besides fixing bug, your commit certainly breaks userland
    compatibility. Please consider.
    --
    Coywolf Qi Hunt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-31 10:46    [W:0.021 / U:160.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site