Messages in this thread | | | Date | Fri, 30 Dec 2005 16:12:12 -0800 | From | Greg KH <> | Subject | Re: [PATCH 8 of 20] ipath - core driver, part 1 of 4 |
| |
On Fri, Dec 30, 2005 at 03:47:07PM -0800, Bryan O'Sullivan wrote: > On Fri, 2005-12-30 at 00:39 -0800, Greg KH wrote: > > > > +void ipath_chip_done(void) > > > +{ > > > +} > > > + > > > +void ipath_chip_cleanup(struct ipath_devdata * dd) > > > +{ > > > +} > > > > What are these two empty functions for? > > They're just as dead as they look.
Then you might want to remove them :)
> > > +static ssize_t show_status_str(struct device *dev, > > > how big can this "status string" be? > > Just a few dozen bytes. > > > If it's even getting close to > > PAGE_SIZE, this doesn't need to be a sysfs attribute, but you should > > break it up into its individual pieces. > > Do you think that's still warranted, given this?
No I don't, unless you think that message will grow somehow...
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |