lkml.org 
[lkml]   [2005]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Fix user data corrupted by old value return of sysctl
    Date
    Yi Yang  wrote:
    >If the user reads a sysctl entry which is of string type
    > by sysctl syscall, this call probably corrupts the user data
    > right after the old value buffer, the issue lies in sysctl_string
    > seting 0 to oldval[len], len is the available buffer size
    > specified by the user, obviously, this will write to the first
    > byte of the user memory place immediate after the old value buffer
    >, the correct way is that sysctl_string doesn't set 0, the user
    >should do it by self in the program.

    That's not just data corruption -- it's also a buffer overrun.
    Granted, it's "only" a one-byte overrun, but I have seen one-byte
    overruns be exploitable occasionally in the past. So this sounds
    to me like a potential security issue, too.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-30 23:35    [W:0.023 / U:124.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site