Messages in this thread | | | Date | Wed, 28 Dec 2005 08:55:54 -0600 | From | Matt Mackall <> | Subject | Re: [PATCH 1 of 3] Introduce __memcpy_toio32 |
| |
On Wed, Dec 28, 2005 at 06:47:42AM -0800, Bryan O'Sullivan wrote: > > > +extern void fastcall __memcpy_toio32(volatile void __iomem *to, const void *from, size_t count); > > > + > > > > Minor rant: extern is always redundant for function prototypes in C. > > I know. My intent was to keep the prototype consistent with the > prevailing style of other declarations in that same routine. If you > think that cleanliness is more important, I'll be happy to change it.
No, I'm actually just raising it for discussion. I personally don't add them, even for consistency, as I'd like to eventually see them gone. But if Christoph and Andrew won't care, my tiny crusade is probably lost.
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |