Messages in this thread | | | Date | Sun, 25 Dec 2005 18:34:06 +0000 | From | Al Viro <> | Subject | Re: [PATCH] lib: zlib_inflate "r.base" uninitialized compile warnings |
| |
On Sun, Dec 25, 2005 at 10:07:58AM -0800, Kees Cook wrote: > Eliminates compile-time warnings from "r" being uninitialized.
NAK. That sort of patches is only going to hide real problems in the code where such warnings are _not_ false positives.
Let me put it that way: what bug are you fixing in that patch? Is there a codepath that would lead to use of r without initialization? If there is - show it; if there is not - why are you patching kernel and not gcc? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |