lkml.org 
[lkml]   [2005]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] forcedeth: fix random memory scribbling bug
Linus Torvalds wrote:

>Of course, on the alloc path, it seems to add an additional
>"NV_RX_ALLOC_PAD" thing, so maybe the "end-data" thing makes sense.
>
>
>
The problem is the pci_unmap_single() call that happens during
nv_close() or the rx interrupt handler. I think it makes more sense to
rely on fields in the individual skb instead of reading from
np->rx_buf_sz. If np->rx_buf_sz changes inbetween, then we have a memory
leak.

--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-24 20:58    [W:0.055 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site