Messages in this thread | | | Date | Sat, 24 Dec 2005 12:13:26 -0600 | Subject | Re: [PATCH] - Fix memory ordering problem in wake_futex() | From | Olof Johansson <> |
| |
Hi,
On Sat, Dec 24, 2005 at 07:45:23AM -0600, Jack Steiner wrote: > This patch is identical to the first patch except I used smp_wmb() instead > of wmb(). Ordering doen't matter on non-SMP kernels.
Ok, I guess I was wrong -- there's no guarantee that protects stuff from bleeding into a critical region from after it. Comments in line 54-58 of kernel/wait.c seems to imply this. Nevermind the fact that most other architectures seem to protect it anyway. :-)
However, please do fix the comment earlier in the function that implies that the unlock does indeed do enough barriers while you're at it, since it seems to be incorrect and misleading.
-Olof - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |