lkml.org 
[lkml]   [2005]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [WTF?] sys_tas() on m32r
    From
    Date
    On Fri, 2005-12-23 at 05:55 -0800, Andrew Morton wrote:
    > Al Viro <viro@ftp.linux.org.uk> wrote:
    > >
    > > asmlinkage int sys_tas(int *addr)
    > > {
    > > int oldval;
    > > unsigned long flags;
    > >
    > > if (!access_ok(VERIFY_WRITE, addr, sizeof (int)))
    > > return -EFAULT;
    > > local_irq_save(flags);
    > > oldval = *addr;
    > > if (!oldval)
    > > *addr = 1;
    > > local_irq_restore(flags);
    > > return oldval;
    > > }
    > > in arch/m32r/kernel/sys_m32r.c. Trivial oops *AND* ability to trigger
    > > IO with interrupts disabled.
    >
    > Yeah. I pointed this out to Takata in October last year and then promptly
    > forgot about it. It's rather amazing that this code (which appears to be in
    > live use in linuxthreads) hasn't generated oopses.

    No one uses LinuxThreads anymore?

    Even the oldest of the old (Debian stable) have moved to NPTL.

    Lee

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-23 20:08    [W:0.021 / U:4.032 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site