Messages in this thread | | | Date | Thu, 22 Dec 2005 13:45:06 +0100 | From | Ingo Molnar <> | Subject | Re: [patch 0/9] mutex subsystem, -V4 |
| |
* Christoph Hellwig <hch@infradead.org> wrote:
> > Changes since -V3: > > > > - imlemented an atomic_xchg() based mutex implementation. It integrated > > pretty nicely into the generic code, and most of the code is still > > shared. > > > > - added __ARCH_WANT_XCHG_BASED_ATOMICS: if an architecture defines > > this then the generic mutex code will switch to the atomic_xchg() > > implementation. > > > > This should be conceptually equivalent to the variant Nicolas Pitre > > posted - Nicolas, could you check out this one? It's much easier to > > provide this in the generic implementation, and the code ends up > > looking cleaner. > > > > - eliminated ARCH_IMPLEMENTS_MUTEX_FASTPATH: there's no need for > > architectures to override the generic code anymore, with the > > introduction of __ARCH_WANT_XCHG_BASED_ATOMICS. > > > > - ARM: enable __ARCH_WANT_XCHG_BASED_ATOMICS. > > I must admit I really really hat __ARCH_ stuff if we can avoid it. An > <asm/mutex.h> that usually includes two asm-generic variants is > probably a much better choice.
agreed. In my tree i've changed it to CONFIG_MUTEX_XCHG_ALGORITHM, which is selected by ARM in its Kconfig.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |