lkml.org 
[lkml]   [2005]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] SPI core: turn transfers to be linked list
David Brownell wrote:

>>The list setting commands are pretty essential and will not add a lot to
>>the assembly code.
>>
>>
>
>I'm not totally averse to such changes, but you don't seem to be making
>the best arguments. Example: they're clearly not "essential" because
>transfer queues work today with the lists at the spi_message level.
>
>
One more reason for that that came out only recently: suppore we're
adding transfers to an already configured message (i. e. with some
transfers set up already). This 'chaning' may happen for some kinds of
devices. And in case transfers is an array, we should either be apriory
aware of whether the chaining will take place or allocate an array large
enough to hold additional transfers. Neither of these look good to me,
and having a linked list of transfers will definitely solve this problem.

Vitaly

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-21 14:24    [W:1.753 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site