Messages in this thread | | | Date | Wed, 21 Dec 2005 02:41:33 -0800 | From | Andrew Morton <> | Subject | Re: [RFC: 2.6 patch] include/linux/irq.h: #include <linux/smp.h> |
| |
Adrian Bunk <bunk@stusta.de> wrote: > > The #include <asm/smp.h> in irq.h was intruduced in 2.6.15-rc. > > Since include/linux/irq.h needs code from asm/smp.h only in the > CONFIG_SMP=y case and linux/smp.h #include's asm/smp.h only in the > CONFIG_SMP=y case, I'm suggesting this patch to #include <linux/smp.h> > in irq.h. > > I've tested the compilation with both CONFIG_SMP=y and CONFIG_SMP=n > on i386. > > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- linux-2.6.15-rc6/include/linux/irq.h.old 2005-12-20 21:45:57.000000000 +0100 > +++ linux-2.6.15-rc6/include/linux/irq.h 2005-12-20 21:46:08.000000000 +0100 > @@ -10,7 +10,7 @@ > */ > > #include <linux/config.h> > -#include <asm/smp.h> /* cpu_online_map */ > +#include <linux/smp.h> > > #if !defined(CONFIG_ARCH_S390)
Yes, it's basically always wrong to include asm/foo.h when linux/foo.h exists. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |