Messages in this thread | | | Date | Tue, 20 Dec 2005 23:10:07 -0800 | From | Chris Leech <> | Subject | Fwd: [RFC][PATCH 4/5] I/OAT DMA support and TCP acceleration |
| |
Sorry, bounced from vger the first time due to formatting
---------- Forwarded message ---------- From: Chris Leech <christopher.leech@intel.com> Date: Dec 20, 2005 11:05 PM Subject: Re: [RFC][PATCH 4/5] I/OAT DMA support and TCP acceleration To: Eric Dumazet <dada1@cosmosbay.com> Cc: lkml <linux-kernel@vger.kernel.org>, netdev <netdev@vger.kernel.org>, "Grover, Andrew" <andrew.grover@intel.com>, "Ronciak, John" <john.ronciak@intel.com>
On 12/20/05, Eric Dumazet <dada1@cosmosbay.com> wrote: > Please consider not enlarging cb[] if not CONFIG_NET_DMA ? > > I mean, most machines wont have a compatable NIC, so why should they pay the > price (memory, cpu) in a critical structure named sk_buff ? > > #ifdef CONFIG_NET_DMA > typedef dma_cookie_t net_dma_cookie_t; > #else > typedef struct {} net_dma_cookie_t; > #endif > > ... > > char cb[40+sizeof(net_dma_cookie_t)]; >
That could be a good way to deal with it. Actually, I should double check the length of tcp_skb_cb. I took a quick look and thought that there might be some room left there anyway, even though the comment in tcp.h says otherwise.
-Chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |