lkml.org 
[lkml]   [2005]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 05/15] Generic Mutex Subsystem, mutex-core.patch

* Oleg Nesterov <oleg@tv-sign.ru> wrote:

> > +start_mutex_timer(struct timer_list *timer, unsigned long time,
> > + unsigned long *expire)
> > +{
> > + *expire = time + jiffies;
> > + init_timer(timer);
> > + timer->expires = *expire;
> > + timer->data = (unsigned long)current;
> > + timer->function = process_timeout;
> > + add_timer(timer);
> > +}
>
> How about
> setup_timer(&timer, process_timeout, (unsigned long)current);
> __mod_timer(&timer, *expire);
> ?

i've removed the timer code from the latest queue - because it's unused
and we can add it back later. But you are right, it was racy (Arjan
noticed the signal race too), because this codepath in -rt relied on
guaranteed lock-passing. (while mutex.c does a trylock)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-12-21 17:05    [W:0.086 / U:8.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site