lkml.org 
[lkml]   [2005]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] block: Better CDROMEJECT
    From
    Date
    On Tue, 2005-12-20 at 21:58 +0100, Jens Axboe wrote:
    > On Tue, Dec 20 2005, john stultz wrote:
    > > On Tue, 2005-12-20 at 21:54 +0100, Jens Axboe wrote:
    > > > On Tue, Dec 20 2005, john stultz wrote:
    > > > > Although from just looking at it, don't you still need to add
    > > > > ALLOW_MEDIUM_REMOVAL in the verify_command() list for this to work?
    > > > >
    > > > > Alternatively, would just the "safe_for_write(ALLOW_MEDIUM_REMOVAL);" in
    > > > > verify_command along with the eject-opens-RW fix have almost the same
    > > > > effect?
    > > >
    > > > The command is already in the safe-for-write list, so you don't have to
    > > > change anything but fix eject to open the device O_RDWR.
    > >
    > > Errr? I don't see it in verify_command() from Linus' current git tree.
    > >
    > > Is there some other name for the same command?
    >
    > It's listed as GPCMD_PREVENT_ALLOW_MEDIUM_REMOVAL.

    Ah! Ok, sorry about that! Indeed then, the eject fix appears to be all
    that is needed.

    Thanks for the clarification.
    -john



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-20 22:01    [W:3.968 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site