Messages in this thread | | | Date | Tue, 20 Dec 2005 21:53:07 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH rc6] block: Fix CDROMEJECT to work in more cases |
| |
On Tue, Dec 20 2005, Ben Collins wrote: > However, I don't see the issue with using READ. We know this isn't a > write operation, we are sending a single command with no data. I know > you say reads are precious, but 3 requests for something that isn't > going to happen very often doesn't seem that bad.
It's not a READ either!
Yes I'm being stubborn, but my point stands. I'm not changing something that is perfectly valid, "just because". If it finds a bug (you mentioned ide-cd, I still want the details on that when you have the time), then it's all for the better since it would bite us for other paths as well.
In summary - it's not a bug, it doesn't need fixing.
> As for the 0x01, I don't know. The eject -s code does the exact same > thing (AMR, SS:0x01, SS:0x02), so I copied the same mechanism because it > is known to work.
Lets leave that out for now then, yes?
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |