Messages in this thread | | | Date | Mon, 19 Dec 2005 16:18:34 +0100 (CET) | From | Roman Zippel <> | Subject | Re: [PATCH 3/3] m68k: compile fix - updated vmlinux.lds to include LOCK_TEXT |
| |
Hi,
On Thu, 15 Dec 2005, Al Viro wrote:
> Speaking of hardirq.h - come on; even argument about check being not > in the same place where the value is defined... > > * we compare NR_IRQS and HARDIRQ_BITS > * one of them is defined in irq.h, another - in hardirq.h > * due to current header ordering, comparison works in irq.h and not in > hardirq.h
I rechecked what I did in the m68k tree. The basic idea is that <asm/irq.h> is mostly a private header (basically our <linux/irq.h>), so if we move something around I would prefer the NR_IRQS definition. I tried that, but it broke a few other dependencies, so I changed it that the (public) hardirq.h includes the (private) irq.h.
Basically what we need is a clear separation between private/public and low/high level irq header. For example <linux/interrupt.h> is high level header (it even pulls in <linux/sched.h>!) but it defines irqreturn_t which is also useful in lower level irq headers.
Christoph, what exactly is your plan regarding irq.h/hardirq.h?
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |