Messages in this thread | | | Date | Sat, 17 Dec 2005 22:52:51 +0100 | From | Adrian Bunk <> | Subject | Re: [PATCH 13/13] [RFC] ipath Kconfig and Makefile |
| |
On Fri, Dec 16, 2005 at 03:48:55PM -0800, Roland Dreier wrote:
>... > --- /dev/null > +++ b/drivers/infiniband/hw/ipath/Kconfig > @@ -0,0 +1,18 @@ > +config IPATH_CORE > + tristate "PathScale InfiniPath Driver" > + depends on PCI_MSI && X86_64 >...
The driver shouldn't use assembler code and therefore no longer depend on X86_64.
> --- /dev/null > +++ b/drivers/infiniband/hw/ipath/Makefile > @@ -0,0 +1,15 @@ > +EXTRA_CFLAGS += -Idrivers/infiniband/include > + > +EXTRA_CFLAGS += -Wall -O3 -g3
-Wall is always set when compiling the kernel.
-O3 doesn't make much sense since the fight for producing the fastest code is between -O2 and -Os.
You don't want to always compile your driver with -g3.
> +_ipath_idstr:="$$""Id: kernel.org InfiniPath Release 1.1 $$"" $$""Date: $(shell date +%F-%R)"" $$" > +EXTRA_CFLAGS += -D_IPATH_IDSTR='$(_ipath_idstr)' -DIPATH_KERN_TYPE=0 >...
Please move the _IPATH_IDSTR revision tag to a header file and remove IPATH_KERN_TYPE.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |