lkml.org 
[lkml]   [2005]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 04/13] [RFC] ipath LLD core, part 1
    From
    Date
    On Sat, 2005-12-17 at 12:38 -0800, Andrew Morton wrote:
    > Roland Dreier <rolandd@cisco.com> wrote:
    > >
    > > + if ((ret = copy_from_user(&rpkt, p, sizeof rpkt))) {
    > > + _IPATH_DBG("Failed to copy in pkt struct (%d)\n", ret);
    > > + return ret;
    > > + }
    >
    > The driver does this quite a lot. copy_from_user() will return the number
    > of bytes remaining to copy. So I think we'll be wanting `return -EFAULT;'
    > in lots of places rather than this.

    Thanks. Will fix.

    Regards,
    Robert.

    --
    Robert Walsh Email: rjwalsh@pathscale.com
    PathScale, Inc. Phone: +1 650 934 8117
    2071 Stierlin Court, Suite 200 Fax: +1 650 428 1969
    Mountain View, CA 94043.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-17 22:37    [W:0.020 / U:29.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site