Messages in this thread | | | Subject | Re: [PATCH 2/2] dasd: remove dynamic ioctl registration | From | Martin Schwidefsky <> | Date | Fri, 16 Dec 2005 17:32:21 +0100 |
| |
On Fri, 2005-12-16 at 16:00 +0100, Christoph Hellwig wrote: > On Fri, Dec 16, 2005 at 03:58:19PM +0100, Martin Schwidefsky wrote: > > On Fri, 2005-12-16 at 15:33 +0100, Christoph Hellwig wrote: > > > dasd has some really messy code to allow submodule to register ioctl. > > > Right now there are two cases: cmd and eckd. > > > > Wrong, at least four: cmf, eckd, err, and a binary only module from EMC. > > Now don't hit me for that binary module. But it has been there for 2.4 > > and we even reserved some ioctl numbers for them (240-255). > > NACK, binary modules are not a reason to keep broken things, rather one > to fix it better sooner than later.
I see your point. We shouldn't have introduced that interface in the first place but we really wanted to be able to run on EMC with decent speed.
> > I would be cautious about ripping out the dynamic ioctls interface > > though. I have no idea if there still is an EMC module for 2.6 or other > > exploiters. It is an exported interface after all. It is not necessary > > to break these exploiters intentionally. > > Yes, it is. Unrelated modules adding ioctls is a big no-way. Even more > for binary modules. The EMC code deserves to be broken.
Ok understood, but at least I have warn the EMC people about that change so that they can send a patch for the dasd driver ..
-- blue skies, Martin
Martin Schwidefsky Linux for zSeries Development & Services IBM Deutschland Entwicklung GmbH
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |