Messages in this thread | | | Date | Wed, 14 Dec 2005 09:24:37 -0700 | From | Matthew Wilcox <> | Subject | Re: [patch 6/6] statistics infrastructure - exploitation: zfcp |
| |
On Wed, Dec 14, 2005 at 05:14:30PM +0100, Martin Peschke wrote: > if (device_register(&unit->sysfs_device)) { > + zfcp_unit_statistic_unregister(unit); > kfree(unit); > return NULL; > } > > if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) { > + zfcp_unit_statistic_unregister(unit); > device_unregister(&unit->sysfs_device); > return NULL; > }
Unrelated, but doesn't that error path forget to release unit?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |