Messages in this thread | | | Date | Mon, 12 Dec 2005 12:20:33 +0100 | From | Petr Baudis <> | Subject | Re: [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig |
| |
Dear diary, on Mon, Dec 12, 2005 at 04:18:26AM CET, I got a letter where Kurt Wall <kwallinator@gmail.com> said that... > On Sunday 11 December 2005 07:46 pm, Petr Baudis wrote: > > After three years, the zombie walks again! This patch (against the latest > > git tree) cleans up interaction between kconfig's mconf (menuconfig > > frontend) and lxdialog. Its commandline interface disappears in this patch, > > instead a .so is packed from the lxdialog objects and the relevant > > functions are called directly from mconf. > > > @@ -808,18 +684,22 @@ static void conf(struct menu *menu) > > } > > break; > > case 4: > > - if (type == 't') > > + if (active_type == 't') > > sym_set_tristate_value(sym, no); > > break; > > case 5: > > - if (type == 't') > > + if (active_type == 't') > > sym_set_tristate_value(sym, mod); > > break; > > case 6: > > - if (type == 't') > > + if (active_type == 't') { > > sym_toggle_tristate_value(sym); > > - else if (type == 'm') > > - conf(submenu); > > + } else if (active_type == 'm') { > > + if (single_menu_mode) > > + submenu->data = (void *) !submenu->data; > > Shouldn't this be: > submenu->data = (void *) (long) !submenu->data;
You are right, it should be so at least for consistency - it'll be fixed in the next resend of the patch. I can't see why is it needed, though - shouldn't the int be padded to void* anyway?
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ VI has two modes: the one in which it beeps and the one in which it doesn't. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |