Messages in this thread | | | Date | Mon, 12 Dec 2005 09:49:44 +0100 | From | Eric Dumazet <> | Subject | Re: [PATCH] Cpuset: rcu optimization of page alloc hook |
| |
Paul Jackson a écrit :
> + > +static kmem_cache_t *cpuset_cache; > +
Hi Paul
Please do use __read_mostly for new kmem_cache :
static kmem_cache_t *cpuset_cache __read_mostly;
If not, the pointer can sit in the midle of a highly modified cache line, and multiple CPUS will have memory cache misses to access the cpuset_cache, while slab code/data layout itself is very NUMA/SMP friendly.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |