lkml.org 
[lkml]   [2005]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 2/4] i386/x86-64: Implement fallback for PCI mmconfig to type1
    On Mon, Dec 12, 2005 at 12:01:23PM -0800, Greg Kroah-Hartman wrote:
    > When there is no entry for a bus in MCFG fall back to type1. This is
    > especially important on K8 systems where always some devices can't be
    > accessed using mmconfig (in particular the builtin northbridge doesn't
    > support it for its own devices)
    [...]
    > -static int pci_conf1_read(unsigned int seg, unsigned int bus,
    > +int pci_conf1_read(unsigned int seg, unsigned int bus,

    I don't like this at all. We already have a mechanism to use different
    accessors per-bus (bus->ops->read()); calling the type1 accessors from
    the mmconfig accessors just seems wrong.

    > + if (!base)
    > + return pci_conf1_read(seg,bus,devfn,reg,len,value);

    Should be space after commas.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-12-12 21:29    [W:0.019 / U:92.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site