Messages in this thread | | | Date | Mon, 12 Dec 2005 00:28:05 +0100 | From | Pavel Machek <> | Subject | Re: swsusp performance problems in 2.6.15-rc3-mm1 |
| |
Hi!
> > > Would that be ok if I made drop_pagecache() nonstatic and called it directly > > > from swsusp? > > > > Sure, I'll updates the patch for that. > > Thanks a lot. > > > It changed a bit.. You'll need to run sys_sync() then drop_pagecache() > > then drop_slab(). > > I think it won't hurt if we do this unconditionally in swsusp_shrink_memory(). > Pavel, what do you think? > > The appended patch illustrates the way in which I think we can use this. > I've tested it a little, but if someone feels like trying it, please > do.
Not sure, do we really want to drop all the pagecache? We want to free memory that is not going to be used soon after suspend, but I guess pagecache can be quite "hot".
I'd certainly wait with this until code settles. And at least trying if it helps or hurts... Pavel
-- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |