Messages in this thread Patch in this message | | | From | Jesper Juhl <> | Subject | [PATCH] Reduce nr of ptr derefs in drivers/pci/hotplug/rpaphp_pci.c | Date | Sun, 11 Dec 2005 06:42:38 +0100 |
| |
Here's a small patch to reduce the nr. of pointer dereferences in drivers/pci/hotplug/rpaphp_pci.c
Benefits: - micro speed optimization due to fewer pointer derefs - generated code should be slightly smaller - better readability
note: due to lack of both hardware and cross-compile tools this patch is, unfortunately, completely untested.
Please review and consider for inclusion.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> ---
drivers/pci/hotplug/rpaphp_pci.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
--- linux-2.6.15-rc5-git1-orig/drivers/pci/hotplug/rpaphp_pci.c 2005-12-04 18:48:04.000000000 +0100 +++ linux-2.6.15-rc5-git1/drivers/pci/hotplug/rpaphp_pci.c 2005-12-11 03:59:31.000000000 +0100 @@ -370,13 +370,14 @@ EXPORT_SYMBOL_GPL(rpaphp_unconfig_pci_ad static int setup_pci_hotplug_slot_info(struct slot *slot) { + struct hotplug_slot_info *hotplug_slot_info = slot->hotplug_slot->info; + dbg("%s Initilize the PCI slot's hotplug->info structure ...\n", __FUNCTION__); - rpaphp_get_power_status(slot, &slot->hotplug_slot->info->power_status); + rpaphp_get_power_status(slot, &hotplug_slot_info->power_status); rpaphp_get_pci_adapter_status(slot, 1, - &slot->hotplug_slot->info-> - adapter_status); - if (slot->hotplug_slot->info->adapter_status == NOT_VALID) { + &hotplug_slot_info->adapter_status); + if (hotplug_slot_info->adapter_status == NOT_VALID) { err("%s: NOT_VALID: skip dn->full_name=%s\n", __FUNCTION__, slot->dn->full_name); return -EINVAL;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |