lkml.org 
[lkml]   [2005]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: typo in debugfs code comments?


--- Greg KH <greg@kroah.com> wrote:
> On Fri, Dec 09, 2005 at 06:01:34PM -0800, Bao Zhao
> wrote:
> > I think that the comments of debugfs_create_u16
> and
> > debugfs_create_u32
> > have the copy and paste error.
> >
> > below is original comments.
> > /**
> > * debugfs_create_u16 - create a file in the
> debugfs
> > filesystem that is used to read and write a
> unsigned 8
> > bit value.
> > *
> >
> > /**
> > * debugfs_create_u32 - create a file in the
> debugfs
> > filesystem that is used to read and write a
> unsigned 8
> > bit value.
> > *
> >
> > It should be "a unsigned 16 bit value" and "a
> unsigned
> > 32 bit value"
>
> Heh, cut and paste comments :)
>
> Care to send me a patch, as per
> Documentation/SubmittingPatches to fix
> this up?
>
> thanks,
>
> greg k-h
>

This patch fixes cut and paste error in debugfs.

Signed-off-by: Zhao Bao <baozhaolinuxer@yahoo.com>

---
--- linux-2.6.14.3/fs/debugfs/file.c.orig 2005-12-03
17:39:41.000000000 -0500
+++ linux-2.6.14.3/fs/debugfs/file.c 2005-12-03
17:41:15.000000000 -0500
@@ -98,7 +98,7 @@ static u64 debugfs_u16_get(void
*data)
DEFINE_SIMPLE_ATTRIBUTE(fops_u16, debugfs_u16_get,
debugfs_u16_set, "%llu\n");

/**
- * debugfs_create_u16 - create a file in the debugfs
filesystem that is used to read and write a unsigned 8
bit value.
+ * debugfs_create_u16 - create a file in the debugfs
filesystem that is used to read and write a unsigned
16 bit value.
*
* @name: a pointer to a string containing the name
of the file to create.
* @mode: the permission that the file should have
@@ -140,7 +140,7 @@ static u64 debugfs_u32_get(void
*data)
DEFINE_SIMPLE_ATTRIBUTE(fops_u32, debugfs_u32_get,
debugfs_u32_set, "%llu\n");

/**
- * debugfs_create_u32 - create a file in the debugfs
filesystem that is used to read and write a unsigned 8
bit value.
+ * debugfs_create_u32 - create a file in the debugfs
filesystem that is used to read and write a unsigned
32 bit value.
*
* @name: a pointer to a string containing the name
of the file to create.
* @mode: the permission that the file should have


__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-12-10 08:52    [from the cache]
©2003-2011 Jasper Spaans