Messages in this thread | | | Date | Tue, 8 Nov 2005 11:59:24 +0100 | From | Jörn Engel <> | Subject | Re: [PATCH 06/25] mtd: move ioctl32 code to mtdchar.c |
| |
On Sat, 5 November 2005 17:26:56 +0100, Arnd Bergmann wrote: > > The MTD ioctls are all specific to mtdchar.c, so the > compat code for them should be there as well. > > Also, some of the ioctl commands used in that driver > were previously not marked as compatible. > > The conversion handlers could be further simplified > by not using compat_alloc_user_space any more. > > CC: dwmw2@infradead.org > CC: linux-mtd@lists.infradead.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Jörn Engel <joern@wh.fh-wedel.de>
Moving crap over to mtdchar.c is a good thing. Complete removal of mtdchar.c might be even better, but at least the crap is relatively self-contained now.
Jörn
-- When in doubt, punt. When somebody actually complains, go back and fix it... The 90% solution is a good thing. -- Rob Landley - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |