Messages in this thread | | | Date | Tue, 08 Nov 2005 11:10:43 -0800 | From | Matthew Dobson <> | Subject | Re: [KJ] [PATCH 4/8] Cleanup kmem_cache_create() |
| |
Pekka J Enberg wrote: > On Tue, 8 Nov 2005, Matthew Wilcox wrote: > >>+/* >>+ * Calculate size (in pages) of slabs, and the num of objs per slab. This >>+ * could be made much more intelligent. For now, try to avoid using high >>+ * page-orders for slabs. When the gfp() funcs are more friendly towards >>+ * high-order requests, this should be changed. >>+ */ >>+static size_t find_best_slab_order(kmem_cache_t *cachep, size_t size, >>+ size_t align, unsigned long flags) >>+{ > > > Looks ok to me. I would prefer this to be called calculate_slab_order() > instead though. > > Pekka
Agreed. Will include this in the next version, due out this afternoon.
Thank you both for the review and comments.
-Matt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |