Messages in this thread | | | Date | Mon, 7 Nov 2005 15:30:53 -0800 | From | William Lee Irwin III <> | Subject | Re: [RFC 1/2] Hugetlb fault fixes and reorg |
| |
On Mon, Nov 07, 2005 at 03:38:16PM -0600, Adam Litke wrote: > (Patch originally from David Gibson <david@gibson.dropbear.id.au>) > Initial Post: Tue. 25 Oct 2005 > -static struct page *find_lock_huge_page(struct address_space *mapping, > - unsigned long idx) > +static struct page *find_or_alloc_huge_page(struct address_space *mapping, > + unsigned long idx) > { > struct page *page; > int err; > - struct inode *inode = mapping->host; > - unsigned long size;
This patch is a combination of function renaming, variable initialization/assignment and return path/etc. oddities, plus some functional changes (did I catch them all?) which apparently took a bit of effort to get to after sifting through the rest of that.
Dump the parallel cleanups or split them into pure cleanup and pure functional patches. I don't mind the cleanups, I mind the mixing.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |