lkml.org 
[lkml]   [2005]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7]: PCI revised [PATCH 16/42]: PCI: PCI Error reporting callbacks
On Mon, Nov 07, 2005 at 01:57:27PM -0600, linas wrote:
> On Mon, Nov 07, 2005 at 10:27:27AM -0800, Greg KH was heard to remark:
> > 3) realy strong typing that sparse can detect.
>
>
> PCI Error Recovery: header file patch
>
> Change enums and subroutine signatures to be strongly typed, per recent
> discussion with GregKH. Also, change the acronym to the more unique,
> less generic "PERS" "PCI Error Recovery System".
>
> Greg, Please apply.
>
> Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
>
> --
> Index: linux-2.6.14-mm1/include/linux/pci.h
> ===================================================================
> --- linux-2.6.14-mm1.orig/include/linux/pci.h 2005-11-07 13:55:28.528843983 -0600
> +++ linux-2.6.14-mm1/include/linux/pci.h 2005-11-07 13:55:35.745830682 -0600
> @@ -82,11 +82,11 @@
> * the pci device. If some PCI bus between here and the pci device
> * has crashed or locked up, this info is reflected here.
> */
> -enum pci_channel_state {
> +typedef enum {
> pci_channel_io_normal = 0, /* I/O channel is in normal state */
> pci_channel_io_frozen = 1, /* I/O to channel is blocked */
> pci_channel_io_perm_failure, /* PCI card is dead */
> -};
> +} pci_channel_state_t;

No, this doesn't help out at all. Please go look at the __bitwise
documentation.

Good luck,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-07 21:10    [W:0.186 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site