Messages in this thread | | | Date | Sat, 5 Nov 2005 14:46:36 +0100 | From | Thomas Graf <> | Subject | Re: [PATCH] [IPV4] Fix secondary IP addresses after promotion |
| |
* Patrick McHardy <kaber@trash.net> 2005-11-05 05:28 > The reason why all routes are deleted is because their prefered > source addresses is the primary address. fn_flush_list should > probably send the missing notifications for the deleted routes. > Changing address promotion to not delete the other routes at all > looks extremly complicated, I think just fixing it to behave > correctly is good enough (which my patch didn't do entirely, > I'll send a new one this weekend).
Yes, fib_sync_down(), but even when I remove the code setting RTNH_F_DEAD I still see _some_ local routes disappearing which I cannot explain right now. I can only reproduce this with !CONFIG_IP_MULTIPLE_TABLES though.
Assuming this is a separate bug, I'm not sure if this is the right way to fix it. I think it would be better to rewrite the preferred source address of all related local routes and only perform a remove-and-add on the secondary address being promoted.
_If_ we let them die, we should announce it in fib_sync_down() rather then in the algorithm specific flush routines. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |