lkml.org 
[lkml]   [2005]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.14-git3: scheduling while atomic from cpufreq on Athlon64
    On Fri, Nov 04, 2005 at 02:30:35PM -0800, Andrew Morton wrote:
    > Ashok Raj <ashok.raj@intel.com> wrote:
    > >
    > >
    > > ...
    > >
    > > seems ugly, but i dont find a better looking cure...
    > >
    >
    > Could you take another look, please? It really is pretty gross.

    Agree, frankly i didnt like this either, but the calls there were so
    nested that i tried doing multiple ways and it appeared they need
    to be broken down so much to do this a little cleanly.

    i did put a real ugly comment earlier, but i must have removed it in the next
    respin.

    I was hoping to do just make the dirs appear/disapper (so i get the
    behaviour i need) and let people more familier with the code go fix it.


    >
    > And the second rule of pretty-gross code is to clearly comment it - draw
    >

    pretty-gross.... humbly saying that is :-) i will attempt to look at it
    again.

    cpufreq folks... if you have better ideas brewing to make this work
    in a pretty-clean way.... many thanks!

    Cheers,
    ashok
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-05 01:03    [W:2.489 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site