Messages in this thread | | | Date | Sat, 5 Nov 2005 00:51:48 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 4/4] ->compat_ioctl for 390 tape_char |
| |
On Sat, Nov 05, 2005 at 12:10:46AM +0100, Arnd Bergmann wrote: > Hmm, isn't ->compat_ioctl called before the translation lookup?
Yes.
> If so, > this code would return -EINVAL from tape_34xx_ioctl and result in never > entering the conversion for MTIO* at all.
we return -ENOIOCTLCMD if we didn't have a valid compat ioctl, and in that case the vfs code will try to find it in the core translation table.
> BTW, I now have a set of 25 patches that moves all handlers from > fs/compat_ioctl.c over to the respective drivers and subsystems, > but I'm not sure how to best test that. > I intend to at least give it a test run on my Opteron for the whatever > ioctls I normally use, but the rest is just guesswork. Christoph, > can you review those patches?
I'm not sure moving everything from fs/compat_ioctl.c is a good idea. Everything that is just in a single driver or subsystem that has common ioctl code - sure. else it doesn't make a lot of sense.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |