lkml.org 
[lkml]   [2005]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH/RFC] simple SPI controller on PXA2xx SSP port, refresh
From
Date
On Thu, 2005-11-03 at 16:15 -0800, David Brownell wrote:
> Stephen persuaded me to add controller_data too, which is stored in
> "struct spi_device". His PXA SPI controller driver uses that for a
> structure holding what I'd call DMA tuning information, plus a function
> that tweaks the GPIO used for a chipselect. Treat it as readonly.
>
> Controller drivers can have two different kinds of state in each
> spi_device: static, and dynamic/runtime. The names used for them
> are IMO very confusing (platform_data and controller_data) since
> they don't mean the same as those names do in board_info. I'd take
> a patch to provide better names for those two. :)

I agree, the names are bad... How about modifying struct spi_board_info
to

struct spi_board_info {
...

void *slave_data;
void *master_data;
...
};

-Stephen




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-04 19:55    [W:0.061 / U:0.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site