Messages in this thread Patch in this message | | | Date | Wed, 30 Nov 2005 09:25:33 -0500 | From | Steve Dickson <> | Subject | Re: NFS cache consistancy appears to be broken... |
| |
Hey Trond,
Unfortunately this update patch did not correct the problem for me. So I decided to dig a little deeper since it appears your not in favor of reverting the original patch... and sure your were right in the sense there was "something else at work here"....
It was the simple fact that nfsi->cache_change_attribute was not being initialized to jiffies when the nfs inode was being allocated. This meant when nfs_revalidate_mapping() was called with the NFS_INO_INVALID_DATA bit was on, nfsi->cache_change_attribute was not being changed, it was actually being set!
This caused the next called to nfs_verify_change_attribute() to return true instead false, which meant (indirectly) the dentry was never released and the otw look was not happening even when it was noticed the mtime of the directory had changed....
The attached patch does fix the problem for me.
steved.
Make sure cache_change_attribute is initialized to jiffies so when the mtime changes on directory, the directory will be refreshed.
Signed-off by: Steve Dickson <steved@redhat.com> --------------------------------------------- --- linux-2.6.14/fs/nfs/inode.c.orig 2005-11-29 20:53:57.000000000 -0500 +++ linux-2.6.14/fs/nfs/inode.c 2005-11-30 08:55:14.000000000 -0500 @@ -2066,6 +2066,7 @@ static struct inode *nfs_alloc_inode(str return NULL; nfsi->flags = 0UL; nfsi->cache_validity = 0UL; + nfsi->cache_change_attribute = jiffies; #ifdef CONFIG_NFS_V3_ACL nfsi->acl_access = ERR_PTR(-EAGAIN); nfsi->acl_default = ERR_PTR(-EAGAIN); | |