Messages in this thread | | | Date | Thu, 3 Nov 2005 11:59:39 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] Incorrect device link for ide-cs |
| |
On 11/3/05, Hannes Reinecke <hare@suse.de> wrote: > Bartlomiej Zolnierkiewicz wrote: > > Hi, > > > >> hw_regs_t hw; > >> memset(&hw, 0, sizeof(hw)); > >> - ide_init_hwif_ports(&hw, io, ctl, NULL); > >> + ide_std_init_ports(&hw, io, ctl); > > > > Could you separate this into another patch? > > > > This change fixes ide-cs for some archs but OTOH we should verify that > > there are no ide-cs specific hacks in ide_init_hwif_ports() on other archs. > > > Oops, you are correct. The main reason why I did this is this comment in > include/linux/ide.h: > * ide_init_hwif_ports() is OBSOLETE and will be removed in 2.7 series. > > Arch specific codes are in: > cris/v10 > arm/sa1100 > arch-m68knommu
I'm more worried about indirect PPC32 hacks...
... #ifdef CONFIG_PPC32 if (ppc_ide_md.ide_init_hwif) ppc_ide_md.ide_init_hwif(hw, io_addr, ctl_addr, irq); #endif ...
> Neither of which is using the irq parameter anyway, so it would make > sense to remove that interface completely. > > Updated patch attached.
Thanks, Bartlomiej - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |