Messages in this thread Patch in this message | | | Date | Thu, 3 Nov 2005 18:51:17 -0600 | From | Linas Vepstas <> | Subject | [PATCH 19/42]: ppc64: bugfix: crash on PHB add |
| |
19-rpaphp-crashing.patch
This patch fixes a bug related to dlpar PHB add, after a PHB removal.
-- The crash was due to the PHB not having a pci_dn structure yet, when the phb is being added.
This code survived testing, of adding and removeig the PHB and all slots underneath it, 17 times so far, as of this writing.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
emailed to To: paulus@samba.org Cc: linuxppc64-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz, johnrose@linux.ibm.com, linux-kernel@vger.kernel.org Subject: [PATCH] rpaphp: PCI Hotplug crash on PHB DLPAR add
on 4 October 2005
Index: linux-2.6.14-git3/drivers/pci/hotplug/rpadlpar_core.c =================================================================== --- linux-2.6.14-git3.orig/drivers/pci/hotplug/rpadlpar_core.c 2005-11-02 14:29:02.115685162 -0600 +++ linux-2.6.14-git3/drivers/pci/hotplug/rpadlpar_core.c 2005-11-02 14:35:52.800111285 -0600 @@ -306,7 +306,7 @@ { struct pci_controller *phb; - if (PCI_DN(dn)->phb) { + if (PCI_DN(dn) && PCI_DN(dn)->phb) { /* PHB already exists */ return -EINVAL; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |