lkml.org 
[lkml]   [2005]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 10/42]: ppc64: bugfix: don't silently gnore PCI errors
    10-EEH-enable-bugfix.patch

    Bugfix: With the curent linux-2.6.14-rc2-git6, EEH errors are
    ignored because thier detection requires an unusued, uninitialized
    flag to be set. This patch removes the unused flag.

    Signed-off-by: Linas Vepstas <linas@austin.ibm.com>


    Index: linux-2.6.14-git3/arch/ppc64/kernel/eeh.c
    ===================================================================
    --- linux-2.6.14-git3.orig/arch/ppc64/kernel/eeh.c 2005-10-31 12:54:20.919034814 -0600
    +++ linux-2.6.14-git3/arch/ppc64/kernel/eeh.c 2005-10-31 12:54:48.165215962 -0600
    @@ -631,11 +631,12 @@
    pdn = PCI_DN(dn);

    /* Access to IO BARs might get this far and still not want checking. */
    - if (!pdn->eeh_capable || !(pdn->eeh_mode & EEH_MODE_SUPPORTED) ||
    + if (!(pdn->eeh_mode & EEH_MODE_SUPPORTED) ||
    pdn->eeh_mode & EEH_MODE_NOCHECK) {
    __get_cpu_var(ignored_check)++;
    #ifdef DEBUG
    - printk ("EEH:ignored check for %s %s\n", pci_name (dev), dn->full_name);
    + printk ("EEH:ignored check (%x) for %s %s\n",
    + pdn->eeh_mode, pci_name (dev), dn->full_name);
    #endif
    return 0;
    }
    Index: linux-2.6.14-git3/include/asm-ppc64/pci-bridge.h
    ===================================================================
    --- linux-2.6.14-git3.orig/include/asm-ppc64/pci-bridge.h 2005-10-31 12:54:20.919034814 -0600
    +++ linux-2.6.14-git3/include/asm-ppc64/pci-bridge.h 2005-10-31 12:54:48.167215682 -0600
    @@ -63,7 +63,6 @@
    int devfn; /* for pci devices */
    int eeh_mode; /* See eeh.h for possible EEH_MODEs */
    int eeh_config_addr;
    - int eeh_capable; /* from firmware */
    int eeh_check_count; /* # times driver ignored error */
    int eeh_freeze_count; /* # times this device froze up. */
    int eeh_is_bridge; /* device is pci-to-pci bridge */
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-11-04 01:52    [W:0.038 / U:4.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site