lkml.org 
[lkml]   [2005]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/12: eCryptfs] Keystore
On Wed, 2 Nov 2005, Phillip Hellewell wrote:

> + password_s_ptr = &auth_tok->token.password;
> + if (password_s_ptr->session_key_encryption_key_set) {
> + ecryptfs_printk(1, KERN_NOTICE, "Session key encryption key "
> + "set; skipping key generation\n");
> + goto session_key_encryption_key_set;
> + }
> + session_key_encryption_key_set:
> + ecryptfs_printk(1, KERN_NOTICE, "Session key encryption key (size [%d])"
> + ":\n", password_s_ptr->session_key_encryption_key_size);

Spurious goto?

> +out:
> + if (tfm)
> + crypto_free_tfm(tfm);
> + return rc;

Just call crypto_free_tfm() unconditionally.


- James
--
James Morris
<jmorris@namei.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-04 01:02    [from the cache]
©2003-2011 Jasper Spaans