lkml.org 
[lkml]   [2005]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/12: eCryptfs] Superblock operations
    On Wed, 2 Nov 2005, Phillip Hellewell wrote:

    > +static struct inode *ecryptfs_alloc_inode(struct super_block *sb) {
    > + struct ecryptfs_inode_info *ecryptfs_inode = NULL;
    > + struct inode *inode = NULL;
    > + ecryptfs_printk(1, KERN_NOTICE, "Enter; sb = [%p]\n", sb);
    > + ecryptfs_inode = ecryptfs_kmem_cache_alloc(ecryptfs_inode_info_cache,
    > + SLAB_KERNEL);

    Most of the kernel code separates variable declarations from code. Please
    do this with your code.

    For debugging and tracing, have a look at the ocfs2 masklog code. (It'd
    be nice to see something like that as a general kernel feature).


    - James
    --
    James Morris
    <jmorris@namei.org>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-11-04 00:50    [W:0.020 / U:92.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site