lkml.org 
[lkml]   [2005]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 30/37] dvb: add nxt200x frontend module
Andrew Morton wrote:

>Michael Krufky <mkrufky@m1k.net> wrote:
>
>>+
>>+static int nxt200x_writetuner (struct nxt200x_state* state, u8* data)
>>+{
>>+ u8 buf, count = 0;
>>+
>>+ dprintk("%s\n", __FUNCTION__);
>>+
>>+ dprintk("Tuner Bytes: %02X %02X %02X %02X\n", data[0], data[1], data[2], data[3]);
>>+
>>+ /* if pll is a Philips TUV1236D then write directly to tuner */
>>+ if (strcmp(state->config->pll_desc->name, "Philips TUV1236D") == 0) {
>>
>>
>Does DVB have a better way of identifying a device type than strcmp?
>
>
I said the same thing when I first saw this, but I wanted to send the
patches separately, because Kirk wrote the driver, and I corrected the
above issue in a separate patch:

dvb-determine-tuner-write-method-based-on-nxt-chip.patch

Feel free to fold them if you like... I was only trying to indicate separate authorship.

As for the other comments for the rest of the patch series, some of the fixes are trivial. Should I expect that you will correct these? or do you need me to send you more patches?

For now, I think the corrections should wait for Johannes' return,
unless you want to take care of them. I think he comes back JUST after
the end of the merge window... not quite sure.

I have 3 or 4 more patches coming.... I plan to send before the end of
tonight.

Regards,

Michael Krufky


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-03 23:59    [W:0.046 / U:1.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site