lkml.org 
[lkml]   [2005]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hpfs: Whitespace and Codingstyle cleanup for dir.c
Hi

> Hi,
>
> On Tue, 2005-11-29 at 16:17 +0100, Jesper Juhl wrote:
>> Well, as Pekka Enberg also pointed out, Documentation/CodingStyle says
>> that's not the prefered way. But, it's your code, so if you don't like
>> the cleanups don't apply them.
>> i still think the patch is a good idea and makes the file more
>> readable though.

I think: if you are going to hack the hpfs code and coding style patches
will improve your experience, apply them and push them into mainstream
kernel. Otherwise don't --- they wouldn't help anybody and they would make
patch merging between 2.0, 2.2, 2.4 and 2.6 version of this driver (yes
--- I keep all these synchronised) harder.
Mikulas

> I also think the patches are a good idea but it is up to the maintainer,
> of course.
>
> Pekka
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-29 21:38    [from the cache]
©2003-2011 Jasper Spaans