Messages in this thread | | | Date | Mon, 28 Nov 2005 23:12:03 +0530 | From | Dipankar Sarma <> | Subject | Re: [PATCH] Allow lockless traversal of notifier lists |
| |
On Mon, Nov 28, 2005 at 05:27:09PM +0100, Andi Kleen wrote: > On Mon, Nov 28, 2005 at 09:47:47PM +0530, Dipankar Sarma wrote: > > On Mon, Nov 28, 2005 at 05:05:47PM +0100, Andi Kleen wrote: > > > * > > > * Returns zero on success, or %-ENOENT on failure. > > > */ > > > @@ -175,6 +181,7 @@ > > > > > > > There should be an smp_read_barrier_depends() here for the first > > dereferencing of the notifier block head, I think. > > Why? The one at the top of the block should be enough, shouldn' it? >
Don't we insert at the front of the list ? Shouldn't the read-side on alpha see the contents of the new notifier block before it sees the pointer to the first notifier block in the list head ?
Thanks Dipankar - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |