Messages in this thread | | | Subject | Re: [PATCH] Fix USB suspend/resume crasher | From | Benjamin Herrenschmidt <> | Date | Fri, 25 Nov 2005 08:01:27 +1100 |
| |
> > Well, it's there (actually the problem occurs in vanilla 2.6.15-rc2-mm1 that > contains the patch). Do you mean it should go before the > > if (readl(&ehci->regs->configured_flag) != FLAG_CF) > goto restart; > > thing?
Yes.
> > It may be worth following it with a memory barrier actually... just in case > > (due to the absence of locks in that area). > > wmb()?
Yup.
I wrote that patch against a tree that had different things in that function, Greg merged it by hand but he got that little bit wrong unfortunately. I'll send a new patch later today.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |