Messages in this thread | | | From | Neil Brown <> | Date | Thu, 24 Nov 2005 16:29:28 +1100 | Subject | Re: Please help me understand ->writepage. Was Re: segfault mdadm --write-behind, 2.6.14-mm2 (was: Re: RAID1 ramdisk patch) |
| |
On Tuesday November 22, aia21@cam.ac.uk wrote: > On Tue, 22 Nov 2005, Neil Brown wrote: > > I've made them all kmap_atomic. > > Except you did it wrong... See below... > > > - kunmap(bitmap->sb_page); > > + kunmap_atomic(bitmap->sb_page, KM_USER0); > > You need to pass in the address not the page, i.e.: >
How.. umm... intuitive :-( Thanks, I'll fix that.
> > Hope this helps. >
It does. I really appreciate getting feedback on my code.... I've sometimes tempted to slip in a few bugs so that when people point them out to me I know they have read the rest of the code and that increases my confidence in it (I haven't actually done this... yet).
:-)
NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |