lkml.org 
[lkml]   [2005]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static
On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote:
> On Wed, 23 Nov 2005, Adrian Bunk wrote:
>
> > Every inline dummy function should be static.
>
> Please explain why it matters in this case.

We don't need an additional global copy of the function.

> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.15-rc2-mm1-full/init/main.c.old 2005-11-23 16:50:45.000000000 +0100
> > +++ linux-2.6.15-rc2-mm1-full/init/main.c 2005-11-23 16:50:55.000000000 +0100
> > @@ -101,7 +101,7 @@
> > static inline void acpi_early_init(void) { }
> > #endif
> > #ifndef CONFIG_DEBUG_RODATA
> > -inline void mark_rodata_ro(void) { }
> > +static inline void mark_rodata_ro(void) { }
> > #endif
> >
> > #ifdef CONFIG_TC
>
> --
> ~Randy

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-23 23:57    [W:0.164 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site