Messages in this thread | | | Date | Wed, 23 Nov 2005 20:49:27 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] split sharpsl_pm.c into generic and corgi/spitz specific parts |
| |
Hi!
> > I'd like to see it applied... > > This diff looks much neater than the last one and I agree with the > principle of it. I don't think its the right time to apply it for two > reasons: > > 1. We probably shouldn't (can't?) make changes like this in -rc > kernels
No, it does not really belong in -rc. I was hoping you would merge it in your tree so I do not have big patch here and could keep only collie changes...
> I have a proposal for how we proceed with this: > > After 2.6.15 is released, I envisage a patch which splits the common > sections of sharpsl_pm.c into arm/common and arm/mach-pxa/sharpsl.h into > include/arm/hardware/sharpsl_pm.h. I'm happy to generate that patch if > necessary and pass it to Russell. I'll try and create a patch to show > the structure I'm aiming for in the next couple of days but at the > moment we don't know exactly which code is common and I'd prefer to try > and do the split in one go.
Ok, works for me. So I'll now concentrate on getting collie working and leave infrastructure to you...
> I did note your patch adds a copyright header to a file you're mostly > deleting code from?
I actually did add some collie parts into it, and then deleted everything #ifdef collie from that. Sorry. Pavel -- Thanks, Sharp! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |