Messages in this thread | | | Date | Wed, 23 Nov 2005 13:02:59 -0600 (CST) | From | Kumar Gala <> | Subject | Re: [PATCH] powerpc: Add support for building uImages |
| |
On Wed, 23 Nov 2005, Sam Ravnborg wrote:
> On Wed, Nov 23, 2005 at 12:43:15PM -0600, Kumar Gala wrote: > > + > > +$(obj)/uImage: $(obj)/vmlinux.gz > > + $(Q)rm -f $@ > > + $(call if_changed,uimage) > > + @echo -n ' Image: $@ ' > > + @if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi > > The above is suboptimal. The $(call if_changed,uimage) will execute > $(cmd_uimage) if 1) prerequisites has changed or 2) the command to execute > has changed. > In the above case 1) is always true, otherwise we would not reach the > statement. So change it to $(call cmd,uimage) is the correct way. > > The 'bug' is also present in ppc/boot/images
thanks. I'll send a follow up patch to fix both cases.
- kumar
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |