lkml.org 
[lkml]   [2005]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 2.6.15-rc2
Linus Torvalds <torvalds@osdl.org> wrote:
>
> On Tue, 22 Nov 2005, Andrew Morton wrote:
> > >
> > > Why does it happen at all, though?
> >
> > davem recently merged a patch which adds ext3 ioctls to fs/compat_ioctl.c.
> > That required inclusion of ext3 and jbd header files. Those files explode
> > unpleasantly when CONFIG_JBD=n.
>
> Oh. How about just making jbd.h do the rigt thing, and not care about the
> configuration?
>
> If we include jbd.h, we want the jbd data structures. There's never any
> reason to care whether jbd is enabled or not afaik.

Yes, that would be the right thing to do.

> ...
> -#if defined(__KERNEL__) && !(defined(CONFIG_JBD) || defined(CONFIG_JBD_MODULE))
> -
> -#define J_ASSERT(expr) do {} while (0)
> -#define J_ASSERT_BH(bh, expr) do {} while (0)
> -#define buffer_jbd(bh) 0
> -#define journal_buffer_journal_lru(bh) 0
> -
> -#endif /* defined(__KERNEL__) && !defined(CONFIG_JBD) */

I guess the core kernel once needed these, but it doesn't (and shouldn't) now.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-23 03:11    [W:0.081 / U:3.392 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site