lkml.org 
[lkml]   [2005]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: 2.6.15-rc2 pci_ids.h cleanup is a pain
Date
Hi Andrew, Greg,

On Tue, 22 Nov 2005 16:25:58 -0800, Andrew Morton <akpm@osdl.org> wrote:

>Greg KH <greg@kroah.com> wrote:
>>
>> On Mon, Nov 21, 2005 at 02:27:23PM -0800, David Fox wrote:
>> > I'm sure I'm not the only person that applies patches to the kernel that
>> > use some of the 500 plus PCI IDS eliminated from pci_ids.h by rc2. I
>> > would like to see the PCI ids that were removed simply because the don't
>> > occur in the main kernel source restored. Is there a rationale for
>> > removing them that I'm not aware of?
>>
>> They were not being used. Why would you want them in there?
>
>Because they contained useful information which had been accumulated by
>many people over a long period of time.
>
>Throwing that information away seemed rather pointless, especially as the
>cost of retaining it was so low.

There's an out-of-tree reference, the pci.ids website, that carries
this information, do we need the reference info in the kernel as well?

So far two people raised an objection, the other wants to maintain
an out-of-tree driver, D. Fox didn't say why he needs the symbols.

There's some other cleanups to be done yet, as >100 files define
own PCI_* symbols instead of referencing the header...


Would you prefer to revert the patches or rather me put the removed
symbols back again via a new patch series?

Cheers,
Grant.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-23 02:54    [W:0.093 / U:14.612 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site